fix: allow DescribeLifecycleHooks for monitor_runner.sh - #1386
Open
uosjead wants to merge 1 commit into
Open
Conversation
Contributor
|
Hey @uosjead! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
Move autoscaling:DescribeLifecycleHooks to Resource "*" (describe APIs do not support resource-level permissions) and scope CompleteLifecycleAction to the Runner Manager ASG that the script actually targets, instead of the worker autoscaler ASG. Co-authored-by: Cursor <cursoragent@cursor.com>
uosjead
force-pushed
the
fix/describe-lifecycle-hooks
branch
from
July 28, 2026 15:23
59decca to
b72aea5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move autoscaling:DescribeLifecycleHooks to Resource "*" (describe APIs do not support resource-level permissions) and scope CompleteLifecycleAction to the Runner Manager ASG that the script actually targets, instead of the worker autoscaler ASG.
Description
fixes an error with the graceful shutdown permissions - noticed in logs prevents graceful shutdown from finishing
Migrations required
No
Verification
Not done.